Hia 623 person search by pnc #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CslBing
approved these changes
Jan 31, 2024
popey2700
added a commit
that referenced
this pull request
Feb 2, 2024
* Updated getPersons to be queried on a pnc number * Updated tests
popey2700
added a commit
that referenced
this pull request
Feb 2, 2024
* Updated getPersons to be queried on a pnc number * Updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is for adding PNC search functionality to our initial entry persons endpoint. This endpoint uses Prisoner and Probation Offender search to return persons information. Complexity is around the Prisoner endpoint which cannot be queried using PNC number only Probation offender search can be queried with PNC.
As a result we take the response from Probation offender search and use the CRN provided to query the Prisoner search.
Changes proposed in this PR